Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud provider oci #1780

Merged
merged 13 commits into from
Feb 14, 2023
Merged

Add cloud provider oci #1780

merged 13 commits into from
Feb 14, 2023

Conversation

rnt
Copy link
Contributor

@rnt rnt commented Jan 21, 2023

ohai cloud fail if the vm is in Oracle Cloud Infrastructure (OCI). This PR add support to this cloud provider to cloud plugin.

Description

Ohai don't detect OCI has a cloud provider, so for cookbook thats require some changes related to the cloud provider, this is a issue.

Following the OCI Metadata Documentation I build this change.

Related Issue

#1779

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@rnt rnt requested review from a team as code owners January 21, 2023 00:41
rnt added 11 commits February 1, 2023 15:05
Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
…s/virtual/dmi/id/chassis_asset_tag'

Signed-off-by: Renato Covarrubias <rnt@rnt.cl>
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely shouldn't fire off the YAJL parser twice if we don't need to.

lib/ohai/mixin/oci_metadata.rb Outdated Show resolved Hide resolved
@tpowell-progress tpowell-progress self-assigned this Feb 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 11 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.1% 6.1% Duplication

@rnt rnt requested a review from jaymzh February 9, 2023 14:45
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jaymzh jaymzh merged commit db9c5e4 into chef:main Feb 14, 2023
@rnt rnt deleted the add-cloud-provider-oci branch February 17, 2023 01:31
@rnt rnt mentioned this pull request Feb 17, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants