Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling yajl parser only once #1786

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Calling yajl parser only once #1786

merged 2 commits into from
Feb 21, 2023

Conversation

rnt
Copy link
Contributor

@rnt rnt commented Feb 17, 2023

In some plugins, YAJL parser is called twice. That's really inefficient.

Description

We definitely shouldn't fire off the YAJL parser twice if we don't need to.

Originally posted by @jaymzh in #1780 (review)

Related Issue

Add cloud provider oci #1780

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@rnt rnt requested review from a team as code owners February 17, 2023 03:19
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rnt rnt mentioned this pull request Feb 17, 2023
Merged
10 tasks
@johnmccrae johnmccrae merged commit 457778a into chef:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-p6 neha-p6 neha-p6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnt @neha-p6 @johnmccrae