initial commit of ohai plugin for vmware #414
Conversation
initial commit of ohai plugin for vmware
|
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. GitHub Users Who Are Not Authorized To ContributeThe following GitHub users do not appear to have signed a CLA: |
|
@drobinson440 I think you'll need to write some unit tests for this functionality. |
| get_vm_attributes("/usr/bin/vmware-toolbox-cmd") | ||
| end | ||
|
|
||
| collect_data(:windows) do |
There was a problem hiding this comment.
We should probably remove this block unless we're supporting windows.
|
A couple notes from Chef code review, and agree we need some test coverage. |
|
Any update on this? Still needs spec tests. |
|
Paging @micgo @mattray ... needs an owner if @drobinson440 doesn't want to work on it anymore |
|
@juliandunn @lamont-granquist @micgo @mattray I would be happy to work on some specs |
|
@cmluciano yes please, that would be greatly appreciated. |
Changed logging level to "debug" and removed the reference to Windows VMware tools.
| vmware Mash.new | ||
| begin | ||
| # vmware-toolbox-cmd stat <param> commands | ||
| # Iterate through each parameter supported by the "vnware-toolbox-cmd stat" command, assign value |
There was a problem hiding this comment.
Very minor typo to fix; I see a couple of instances of 'vnware-toolbox-cmd'; do you mean vmware-toolbox-cmd? Doesn't affect functionality obviously, but is helpful for searching.
There was a problem hiding this comment.
Ya I just noticed these too, I can fix these
|
Closing in favor of #551 |
thommay
added
Type: Enhancement
tas50
added
Triage: Needs Information
initial commit of ohai plugin for vmware