Extra debug logging and error handling in plugin loading #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcquin + @chef/client-core this is ready |
|
👍 |
1 similar comment
|
👍 |
| @@ -219,6 +219,14 @@ | |||
| expect { loader.load_plugin(path_to("bad_name.rb")) }.not_to raise_error | |||
| end | |||
| end | |||
|
|
|||
| describe "when plugin directory does not exist" do | |||
| it "logs and invalid plugin path warning" do | |||
|
teensiest of nits but 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple stuff here. Add the plugin paths and the discovered plugins to debug logging. Add the config too so you can see where we're getting the paths from. Then if you pass in a bogus dir make sure we warn instead of silently continuing like we do now.