Rework / fix logic in the joyent plugin and improve specs #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- condense code - touch up style - don't stat(2) before open(2)
…o bahamas10-dave-1426559693
Nil is used throughout Ohai Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
These specs weren’t covering the actual meat of the plugin. They mocked out the methods, when the methods are where the majority of logic exists. Instead of mocking those methods mock out the files on disk. This also serves to document the structure of the files we’re parsing in the plugin so that’s another win. Signed-off-by: Tim Smith <tsmith@chef.io>
|
It should be noted that the original work is covered under the CLA |
tas50
changed the title
thommay
approved these changes
Nov 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work that @bahamas10 did in #499. It fixes up the specs to provide proper testing of the logic of the plugin and based on those specs makes some additional fixes to the plugin.