Remove deprecated config logic #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
deprecate_old_config
branch
from
4c77cf6
to
2f0f7aa
Compare
|
This is ready for review @thommay / @lamont-granquist |
thommay
approved these changes
Jan 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of the deprecation of the old config logic. Removes a ton of confusing duplicate logic and resolves 2 bogus deprecation warnings that were thrown every time Ohai ran. Specs are going to need to be cleaned up still.
Also bonus gift: This adds /etc/chef/ohai/plugins to the plugin path so the ohai_plugin resource will work without configuration mess by the user now. I'll probably port that same 1 line fix over to Ohai 8.X so we can get that in for Chef 12 users.
Signed-off-by: Tim Smith tsmith@chef.io