Freeze all string values coming out of Ohai. #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This both helps avoid weird mutation bugs and saves a bit of RAM. Refs chef/chef#4930 Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
thommay
approved these changes
Apr 3, 2017
|
although travis is very red. |
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both helps avoid weird mutation bugs and saves a bit of RAM. This does not freeze the hashes or arrays so replacement and whatnot should all work the same. Anyone doing in-place mutation of Ohai strings on purpose is getting what they deserve IMO.
Refs chef/chef#4930 for original discussion.