Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installbuilder packager(installbuilder) #908

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

niekrasp
Copy link

Description

Add new InstallBuilder packager

InstallBuilder is multiplatform packager/tool to build installers.
This packager allows to build linux and windows installers on linux os.


@niekrasp niekrasp requested review from a team as code owners October 28, 2019 16:00
@niekrasp niekrasp force-pushed the installbuilder-packager branch 3 times, most recently from 56fa1ef to 18d7fcd Compare October 29, 2019 10:14
- Allow to build both Linux and Windows installers in single build

Signed-off-by: Przemysław Niekraś <pniekras@ptc.com>
@drorfries
Copy link
Contributor

Hello, I would appreciate if someone from the community can review/approve this

@@ -0,0 +1,381 @@
#
# Copyright 2014-2019 Chef Software, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put your own copyright here instead of ours

@tas50 tas50 added the Type: Enhancement Adds new functionality. label Dec 31, 2019
drorfries added a commit to PTC-Global/omnibus-1 that referenced this pull request Jan 21, 2020
Base on feedback on pull request:
 Add Installbuilder packager(installbuilder) chef#908

From Tim Smith
Copy link
Contributor

@drorfries drorfries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright updated

Base on feedback on pull request:
 Add Installbuilder packager(installbuilder) chef#908

From Tim Smith

Signed-off-by: Fries <dfries@ptc.com>
@drorfries
Copy link
Contributor

@tas50 change pushed per your feedback.
Kindly review/approve.
thanks

@drorfries
Copy link
Contributor

can Code owner please review the required?
thanks

@drorfries
Copy link
Contributor

@tas50 checking again, regarding previous ask.
thanks

@tas50 tas50 merged commit 8e872e6 into chef:master Nov 13, 2020
@tas50
Copy link
Contributor

tas50 commented Nov 13, 2020

Thanks for writing this @nkierpiec

@tas50
Copy link
Contributor

tas50 commented Nov 16, 2020

I had to revert this one due to failures for all chef project and the inability for us to mark this as an opt-in packager:

#985

johnmccrae pushed a commit that referenced this pull request Sep 28, 2022
Base on feedback on pull request:
 Add Installbuilder packager(installbuilder) #908

From Tim Smith

Signed-off-by: Fries <dfries@ptc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants