-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility for autoCorrection #22
Comments
We need to be very rigorous and even if we have the option This means that in
For autocorrection we also need to know for each field if it is only numbers, characters or both. Only field that contains only numbers or characters can be auto corrected. For all the fields (and likely also at the level of We may have to go to the original specification to be sure maybe. |
I'm not agree : |
This would not be scientifically correct because if you have 5 0 or O (which is not unlikely) in the serial number you should try the 2^5 possibilities and it is statistically likely that one of them will match the check digit. So the feature that you suggest would rather be another option. |
Some symbols are difficult to differentiate in the MRZ like the '0' or 'O'.
This PR https://github.com/cheminfo/mrz/pull/21/files#diff-f76f9fb30ec34fcebf47111d3562b71aa630be9dff89cd28fbc4d812ac2b61cbR39-R41 proposes to fix some mistakes as described specifically here:
https://github.com/cheminfo/mrz/pull/21/files#diff-f76f9fb30ec34fcebf47111d3562b71aa630be9dff89cd28fbc4d812ac2b61cbR39-R41
For us it is however important that this 'autoCorrection' is optional (second arguments in the methods, options={}) and that the end-user can be aware that it has been changed in the
result.details
.This 'autoCorrection' should also work all the time it can. Meaning in TD1, TD2 and TD3 as well as from letters to numbers or from numbers to letters if a field can only contain one of the 2.
The text was updated successfully, but these errors were encountered: