Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle digits that are in names. #21

Closed
wants to merge 1 commit into from

Conversation

sam-01et
Copy link

@sam-01et sam-01et commented Dec 7, 2022

There are scenarios where the names and/or other details in the first element from the MRZ code array are represented by digits instead of characters. For exampe, P<UTO3RIKSS0N<<ANNA<MARIA<<<<<<<<<<<<<<<<<<< instead of P<UTOERIKSSON<<ANNA<MARIA<<<<<<<<<<<<<<<<<<<.

This fix serves to handle these kind of scenarios so that digits are mapped to there correct/right equivalent Characters so that we do not have issues when applying regex checks on the results.

There are scenarios where the names and/or other details in the first element from the MRZ code array are represented by digits instead of characters. For exampe, P<UTO3RIKSS0N<<ANNA<MARIA<<<<<<<<<<<<<<<<<<< instead of P<UTOERIKSSON<<ANNA<MARIA<<<<<<<<<<<<<<<<<<<.

This fix serves to handle these kind of scenarios so that digits are mapped to there correct/right equivalent Characters so that we do not have issues when applying regex checks on the results.
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 89.07% // Head: 89.43% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (4d5436c) compared to base (fe011f8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   89.07%   89.43%   +0.35%     
==========================================
  Files          44       44              
  Lines         412      426      +14     
  Branches       83       87       +4     
==========================================
+ Hits          367      381      +14     
  Misses         45       45              
Impacted Files Coverage Δ
src/parse/getResult.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lpatiny
Copy link
Member

lpatiny commented Dec 8, 2022

Thanks for your PR and indeed it is something we would like to implement.

I created an issue about the direction we would go: #22

@targos
Copy link
Member

targos commented Feb 23, 2024

This was fixed last year with a new autocorrect option. Thanks for bringing this to our attention!
#52 adds documentation for it.

@targos targos closed this Feb 23, 2024
@sam-01et
Copy link
Author

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants