fix: fix autocorrections being assigned to the wrong field #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened when multiple field use the same range as the source for parsing. Stopped using previous autocorrected lines to compute next autocorrection and remove any autocorrection that does not finally apply to the final character range of the field.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 88.32% 88.39% +0.06%
==========================================
Files 39 39
Lines 377 379 +2
Branches 95 99 +4
==========================================
+ Hits 333 335 +2
Misses 44 44
☔ View full report in Codecov by Sentry. |
|
Duplicate of #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
This happened when multiple field use the same range as the source for parsing.
Stopped using previous autocorrected lines to compute next autocorrection and remove any autocorrection that does not finally apply to the final character range of the field.