fix: ph0 value starts from zero (#2315)

ph0 input value should start from its last changed value close #2314
cheminfo · Apr 24, 2023 · 5d08c1a · 5d08c1a
1 parent 8035c82
commit 5d08c1a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 18 deletions.
diff --git a/src/component/header/Header.tsx b/src/component/header/Header.tsx
@@ -31,7 +31,7 @@ import AutoPeakPickingOptionPanel from './AutoPeakPickingOptionPanel';
 import BaseLineCorrectionPanel from './BaseLineCorrectionPanel';
 import { HeaderContainer } from './HeaderContainer';
 import { LogsHistory } from './LogsHistory';
-import ManualPhaseCorrectionPanel from './ManualPhaseCorrectionPanel';
+import PhaseCorrectionPanel from './PhaseCorrectionPanel';
 import RangesPickingOptionPanel from './RangesPickingOptionPanel';
 import ZeroFillingOptionsPanel from './ZeroFillingOptionsPanel';
 import Zones2DOptionPanel from './Zones2DOptionPanel';
@@ -109,7 +109,7 @@ function HeaderInner(props: HeaderInnerProps) {
       case options.zeroFilling.id:
         return <ZeroFillingOptionsPanel />;
       case options.phaseCorrection.id:
-        return <ManualPhaseCorrectionPanel />;
+        return <PhaseCorrectionPanel />;
       case options.peakPicking.id:
         return <AutoPeakPickingOptionPanel />;
       case options.rangePicking.id:

diff --git a/...ent/header/ManualPhaseCorrectionPanel.tsx → ...component/header/PhaseCorrectionPanel.tsx b/...ent/header/ManualPhaseCorrectionPanel.tsx → ...component/header/PhaseCorrectionPanel.tsx
@@ -57,7 +57,7 @@ const algorithms = [
 ];
 const emptyData = { datum: {}, filter: null };
 
-export default function ManualPhaseCorrectionPanel() {
+export default function PhaseCorrectionPanel() {
   const {
     toolOptions: {
       data: { pivot },
@@ -139,6 +139,12 @@ export default function ManualPhaseCorrectionPanel() {
     [data.re, dispatch, pivot?.index],
   );
 
+  const updateInputRangeInitialValue = useCallback((value) => {
+    // update InputRange initial value
+    ph0Ref.current.setValue(value.ph0);
+    ph1Ref.current.setValue(value.ph1);
+  }, []);
+
   const handleInput = useCallback(
     (e) => {
       const { name, value } = e.target;
@@ -148,34 +154,23 @@ export default function ManualPhaseCorrectionPanel() {
         if (String(value).trim() !== '-') {
           calcPhaseCorrectionHandler(newValue, name);
         }
-
-        // update InputRange initial value
-        switch (name) {
-          case 'ph0':
-            ph0Ref.current.setValue(newValue.ph0);
-            break;
-          case 'ph1':
-            ph1Ref.current.setValue(newValue.ph1);
-            break;
-          default:
-            break;
-        }
-
+        updateInputRangeInitialValue(newValue);
         valueRef.current = newValue;
         setValue(valueRef.current);
       }
     },
-    [calcPhaseCorrectionHandler],
+    [calcPhaseCorrectionHandler, updateInputRangeInitialValue],
   );
 
   const handleRangeChange = useCallback(
     (e) => {
       const newValue = { ...valueRef.current, [e.name]: e.value };
       calcPhaseCorrectionHandler(newValue, e.name);
+      updateInputRangeInitialValue(newValue);
       valueRef.current = newValue;
       setValue(valueRef.current);
     },
-    [calcPhaseCorrectionHandler],
+    [calcPhaseCorrectionHandler, updateInputRangeInitialValue],
   );
 
   const handleCancelFilter = useCallback(() => {