Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ph0 starts from zero even if ph1 did change it before #2314

Closed
jobo322 opened this issue Apr 21, 2023 · 0 comments · Fixed by #2315 or #2277
Closed

ph0 starts from zero even if ph1 did change it before #2314

jobo322 opened this issue Apr 21, 2023 · 0 comments · Fixed by #2315 or #2277
Assignees
@hamed-musallam

Comments

@jobo322
Copy link
Member

jobo322 commented Apr 21, 2023

bugManualPhaseCorrection2
hamed-musallam added a commit that referenced this issue Apr 24, 2023
@hamed-musallam
fix: ph0 value starts from zero
baabca5 
ph0 input value should start from its last changed value

close #2314
@hamed-musallam hamed-musallam linked a pull request Apr 24, 2023 that will close this issue
fix: ph0 value starts from zero #2315
Merged
@hamed-musallam hamed-musallam mentioned this issue Apr 24, 2023
Merged
hamed-musallam added a commit that referenced this issue Apr 24, 2023
@hamed-musallam
fix: ph0 value starts from zero
80ddc45 
ph0 input value should start from its last changed value

close #2314
jobo322 pushed a commit that referenced this issue Apr 24, 2023
@hamed-musallam
fix: ph0 value starts from zero (#2315)
5d08c1a 
ph0 input value should start from its last changed value

close #2314
@cheminfo-bot cheminfo-bot mentioned this issue Apr 24, 2023
Merged
jobo322 pushed a commit that referenced this issue Apr 24, 2023
@hamed-musallam @jobo322
fix: ph0 value starts from zero (#2315)
01ca989 
ph0 input value should start from its last changed value

close #2314
hamed-musallam added a commit that referenced this issue Apr 25, 2023
@jobo322 @hamed-musallam
fix: do not add empty string for name in migration (#2316)
e33bcab 
* fix: do not add an empty string for the name in the migration

* fix: ph0 value starts from zero (#2315)

ph0 input value should start from its last changed value

close #2314

 fix: avoid double fetching when unzipping files

---------

Co-authored-by: hamed-musallam <35760236+hamed-musallam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamed-musallam hamed-musallam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ph0 value starts from zero cheminfo/nmrium
chore(main): release 0.35.0 cheminfo/nmrium
2 participants
@jobo322 @hamed-musallam