Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls ()/ does not list files in root 2017-03-30 #136

Closed
steve6375 opened this issue Mar 30, 2017 · 9 comments
Closed

ls ()/ does not list files in root 2017-03-30 #136

steve6375 opened this issue Mar 30, 2017 · 9 comments

Comments

@steve6375
Copy link

steve6375 commented Mar 30, 2017

In previous versions

root /_ISO
ls / << lists files in /_ISO
ls ()/ << lists files in root

With new versions
root /_ISO
ls / << lists files in /_ISO
ls ()/ << lists files in /_ISO

cat command is also affected

This breaks batch files, etc, serious bug!

@yaya2007
Copy link
Collaborator

"root /_ISO" usage, grub4dos-0.4.5c-2016-01-18 version also can not do
The correct approach is "root ()/_ISO"

@steve6375
Copy link
Author

steve6375 commented Mar 31, 2017

Sorry - I made typo, BUG is shown below

\menu.lst

root ()/_ISO/e2b/
ls /
echo
echo
ls ()/
pause

image
image

@steve6375
Copy link
Author

Same result if

root ()/_ISO/e2b
ls /
echo
echo
ls ()/
pause

@steve6375
Copy link
Author

steve6375 commented Mar 31, 2017

P.S. re.

VOL_Dir is "xxxx".

Should be Volume Name and also add \n

Volume Name is "xxxx".\n

and The current working directory(i.e., relative path) is
should be just
The current working directory (relative path) is

space before ( and just (relative path)

@steve6375
Copy link
Author

That seems to work.
But current working directory text could be made better?

@yaya2007
Copy link
Collaborator

yaya2007 commented Apr 1, 2017

"But current working directory text could be made better?"
Please explain further

@steve6375
Copy link
Author

steve6375 commented Apr 1, 2017

See comment above.

The current working directory(i.e., relative path) is incorrect English
should be just
The current working directory (relative path) is

space before ( and just (relative path)

image

i.e., is incorrect. Sentences are 'xxxxxx, i.e. yyyyyyy' or use (i.e. relative path). no comma after i.e.
Always use space before (

@steve6375
Copy link
Author

steve6375 commented Apr 1, 2017

FYI: Many other examples where a space should be used but is missing...
image

yaya2007 pushed a commit to yaya2007/grub4dos that referenced this issue Apr 2, 2017
@steve6375
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants