Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sim Details to recording name #177

Closed
hubono opened this issue Nov 27, 2022 · 3 comments · Fixed by #178
Closed

Add Sim Details to recording name #177

hubono opened this issue Nov 27, 2022 · 3 comments · Fixed by #178
Assignees
Labels
enhancement New feature or request

Comments

@hubono
Copy link

hubono commented Nov 27, 2022

Hello
Thanks for your wonderful work.
I would like to request a feature if at all possible.
As the title says, upon saving the sound file, can you please add the sim number to the file name. Most use 2 or 3 Sims. BCR will record all phone calls, it would be nice to be able to tell that which recording happened using what sim.
Cheers

chenxiaolong added a commit that referenced this issue Nov 27, 2022
This only works if all of these conditions are true:
* Android version is >= 11
* The user granted the `READ_PHONE_STATE` permission
* The device supports `FEATURE_TELEPHONY_SUBSCRIPTION`
* The device supports multiple SIMs
* There are currently multiple active SIMs

Fixes: #177

Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
@chenxiaolong chenxiaolong self-assigned this Nov 27, 2022
@chenxiaolong chenxiaolong added the enhancement New feature or request label Nov 27, 2022
@chenxiaolong
Copy link
Owner

Please give the test build at #178 a try. It will add _sim<number> to the filename for multi-SIM devices that run Android 11 or newer.

You'll have to go to Android's settings and manually grant BCR the "phone" permission (which is required to determine the SIM slot of a call).

@hubono
Copy link
Author

hubono commented Nov 28, 2022

Perfect it works.
Cheers for that.
I wanted to suggest another small option. Once a call is completed, a notification currently pops up in the notification area saying recording completed with 2 options, open and share. If u could add delete also to it that will give us the option to delete unwanted recordings right after that call.
Cheers for all your work.

@chenxiaolong
Copy link
Owner

Great, thanks for testing!

I wanted to suggest another small option. Once a call is completed, a notification currently pops up in the notification area saying recording completed with 2 options, open and share. If u could add delete also to it that will give us the option to delete unwanted recordings right after that call.

I like that idea. I've created #179 to track that feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants