Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIM slot ID to the filename if there are multiple active SIMs #178

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Add SIM slot ID to the filename if there are multiple active SIMs #178

merged 1 commit into from
Nov 28, 2022

Conversation

chenxiaolong
Copy link
Owner

This only works if all of these conditions are true:

  • Android version is >= 11
  • The user granted the READ_PHONE_STATE permission
  • The device supports FEATURE_TELEPHONY_SUBSCRIPTION
  • The device supports multiple SIMs
  • There are currently multiple active SIMs

Fixes: #177

@chenxiaolong
Add SIM slot ID to the filename if there are multiple active SIMs
e5fdd8d 
This only works if all of these conditions are true:
* Android version is >= 11
* The user granted the `READ_PHONE_STATE` permission
* The device supports `FEATURE_TELEPHONY_SUBSCRIPTION`
* The device supports multiple SIMs
* There are currently multiple active SIMs

Fixes: #177

Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
@chenxiaolong chenxiaolong self-assigned this Nov 27, 2022
@chenxiaolong
Copy link
Owner Author

Test build: BCR-1.24.r5.ge5fdd8d-debug.zip

@chenxiaolong chenxiaolong mentioned this pull request Nov 27, 2022
Closed
@hubono
Copy link

hubono commented Nov 27, 2022 •
edited

Nice
I will try it now
Do i have to remove the old module and then apply this, or just install this, to over write the old one?

@chenxiaolong
Copy link
Owner Author

Do i have to remove the old module and then apply this, or just install this, to over write the old one?

Nope, no need to uninstall first. It's always OK to upgrade (or even downgrade) BCR just by overwriting.

@chenxiaolong chenxiaolong merged commit 9a2e73f into master Nov 28, 2022
@chenxiaolong chenxiaolong deleted the multisim branch November 28, 2022 19:36
chenxiaolong added a commit that referenced this pull request Nov 28, 2022
@chenxiaolong
changelog.txt: Add entry for PR #178
3bc312a 
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chenxiaolong chenxiaolong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sim Details to recording name
2 participants
@chenxiaolong @hubono