Change "initially paused" preference description #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have separate strings for on/off states, I think it's best to tell user what _will_ happen in the current state, not what they can _tell_ us to do (subtle difference between imperative "start in the paused state" and "will be paused after starting"). chenxiaolong#219 has more or less the same wording, and I thought the English version might use some changes as well.
I know, I know.
chenxiaolong
requested changes
Jan 10, 2023
chenxiaolong
approved these changes
Jan 10, 2023
chenxiaolong
added a commit
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have separate strings for on/off states, I think it's best to tell user what will happen in the current state, not what they can tell us to do (subtle difference between imperative "start in the paused state" and "will be paused after starting").
#219 has the same wording now, and I thought the English version might use some changes as well.
The "on" description could also have the "displayed during a call" part, but this would get too long, wouldn't it?