Fix rare crash in quick settings tile caused by an Android bug #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patryk Miś <foss@patrykmis.com>
PatrykMis
force-pushed
the
upstream/cr-tile-null-check
branch
from
9016f52
to
14e7894
Compare
chenxiaolong
approved these changes
Jul 31, 2023
|
Yet another Android bug 🙁 Thanks for the PR! |
chenxiaolong
added a commit
that referenced
this pull request
Jul 31, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
PatrykMis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.service.quicksettings.Tile.setState(int)' on a null object referenceI'm not absolutely sure if I did it right. This random crash is extremely rare (one on a few weeks/months) and it's not related to any activity, it did never happen while recording.
Probably this PR might improve code safety as a side effect too. ;)