fix std::move warnings from gcc (pytorch#105780)

Pull Request resolved: pytorch#105780 Approved by: https://github.com/Skylion007
chenyang78 · Sep 22, 2023 · cd99cdc · cd99cdc
1 parent 4ff2945
commit cd99cdc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/torch/csrc/api/include/torch/nn/modules/container/sequential.h b/torch/csrc/api/include/torch/nn/modules/container/sequential.h
@@ -118,8 +118,7 @@ class SequentialImpl : public Cloneable<SequentialImpl> {
   explicit SequentialImpl(std::initializer_list<NamedAnyModule> named_modules) {
     modules_.reserve(named_modules.size());
     for (const auto& named_module : named_modules) {
-      push_back(
-          std::move(named_module.name()), std::move(named_module.module()));
+      push_back(named_module.name(), named_module.module());
     }
   }
 
@@ -385,8 +384,7 @@ class Sequential : public torch::nn::ModuleHolder<SequentialImpl> {
   /// It enables the following use case:
   /// `Sequential sequential({{"m1", M(1)}, {"m2", M(2)}})`
   Sequential(std::initializer_list<NamedAnyModule> named_modules)
-      : ModuleHolder(
-            std::make_shared<SequentialImpl>(std::move(named_modules))) {}
+      : ModuleHolder(std::make_shared<SequentialImpl>(named_modules)) {}
 };
 } // namespace nn
 } // namespace torch
diff --git a/torch/csrc/jit/mobile/parse_bytecode.cpp b/torch/csrc/jit/mobile/parse_bytecode.cpp
@@ -24,7 +24,7 @@ IValue expect_field(
       expected_name,
       " found ",
       row->elements().at(0).toStringRef());
-  return std::move(row->elements().at(1));
+  return std::move(row)->elements().at(1);
 }
 
 namespace mobile {