Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Added support for enabling and disabling the three-ar component. #4

Closed
wants to merge 1 commit into from

Conversation

RSpace
Copy link

@RSpace RSpace commented Sep 21, 2017

I needed a way to enable and disable AR on the fly in the my app, so I came with this solution. It's not pretty, and it's a lot of changed and added code, I know. But I think there's a lot of value in being able to enable and disable AR mode on the scene.

@machenmusik
Copy link
Contributor

Can you say more about what you're doing? My original thought was that to toggle between AR and VR, it would be easier to simply use a different camera, but if you need to reuse the same one, then I understand better why you are looking to toggle

@machenmusik
Copy link
Contributor

Thanks for the PR!
From our discussion, it seems that you would indeed like to reuse the camera -- and you're probably in the vast majority there; I am thinking that maybe it would be better to refactor things slightly, so that the ar scene component introduces an ar-camera component on the appropriate camera (specified by selector), that can be enabled / disabled to effect your AR toggling.
With that in mind, I'm going to close this PR and open a corresponding issue.

@RSpace
Copy link
Author

RSpace commented Sep 22, 2017

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants