Weather Module #32
Merged
Weather Module #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you very much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wrote up the beginnings of a weather module, which should address issue #13. It uses the FreeGeoIP API for finding the user's location (I could have used the built-in geolocation API, but there's less browser support and more ability for people to accidentally disable location tracking), and the OpenWeatherMap mentioned on the original issue (I signed up myself with a free account and used the API key here).
Right now, it only has two functions: "what is the weather", and "what is the temperature". I've used a box format with the "what is the weather", similar to the format used with "should I watch" functions. The design doesn't look jaw-dropping, but I think it's decent. I'm pretty sure a little but more modification to the CSS would make it look a lot better, but I didn't spend too much time on that.
I'm sure that the module has lots of room for expansion and improvement. The two APIs I mentioned above can give a lot more information (eg. wind speed/direction, region names, cloudiness, etc.), but I've decided to work on just these two functions right now, because they seem the most "essential" to what a weather module would look like. You could actually probably turn in this into a geography module too, because it gives a lot of information of latitude, longitude, and other stuff. Integrating Google's Maps API would be a really cool feature.
But yeah, here you go.