Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/makefile improve memoryview #137

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Nov 1, 2018

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • tests/coverage improvement
    • refactoring
    • other
  • What is the related issue number (starting with #)

Improves #134 + #133

  • What is the current behavior? (You can also link to an open issue here)

N/A

  • What is the new behavior (if this is a feature change)?

N/A

  • Other information:

N/A

  • Checklist:

    • I think the code is well written
    • I wrote good commit messages
    • I have squashed related commits together after the changes have been approved
    • Unit tests for the changes exist
    • Integration tests for the changes exist (if applicable)
    • I used the same coding conventions as the rest of the project
    • The new code doesn't generate linter offenses
    • Documentation reflects the changes
    • The PR relates to only one subject with a clear title
      and description in grammatically correct, complete sentences

This change is Reviewable

@webknjaz webknjaz requested a review from jaraco November 1, 2018 13:27
@webknjaz
Copy link
Member Author

webknjaz commented Nov 1, 2018

@nav-agarwal ^

@webknjaz webknjaz merged commit ee444e2 into master Nov 1, 2018
webknjaz added a commit that referenced this pull request Nov 1, 2018
PR #137
Merge branch 'bugfix/makefile-improve-memoryview'
@webknjaz
Copy link
Member Author

webknjaz commented Dec 1, 2018

Hey @nav-agarwal so did it work for you?

@nav-agarwal
Copy link

@webknjaz : Yes it is working. I have just validated the functionality and not looked at actual fix.

@webknjaz
Copy link
Member Author

webknjaz commented Dec 4, 2018

Great, thanks!

@webknjaz webknjaz deleted the bugfix/makefile-improve-memoryview branch December 7, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants