Function arguments can get incorrectly appended to comments

[alastair-harrison-oxb]

$ clang-format --version
0.3.6

When I run cmake-format on a code block like this:

my_function(
  item1

  # Some comment
  item2
)

cmake-format gives me the following output:

my_function(item1 # Some comment item2)

There should be a line break before item2.

[sum01]

Isn't this more or less the same as #46 or at least very related? It seems that it's probably the cause of this issue anyways.

[bergercookie]

Isn't this more or less the same as #46 or at least very related? It seems that it's probably the cause of this issue anyways.

Looks like it's related but not the very same issue.

Adding to this, consider the following example

if(NOT CMAKE_BUILD_TYPE)
  set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE)
  # a comment here
endif()

I assume in this case, cmake-format (incorrectly) tries to join the string to the previous line, but this also results in the following exception:

ValueError: invalid width -1 (must be > 0)

Here's the full traceback:

[cheshirekow]

Fixed I believe in the upcoming release. If you're able, please try https://github.com/cheshirekow/cmake_format/releases/tag/v0.4.0rc1 and lte me know how it goes

[alastair-harrison-oxb]

Yes, seems to maintain the semantics of the function call now. Thanks.