Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.12 #370

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Support Python 3.12 #370

merged 1 commit into from
Nov 20, 2023

Conversation

chezou
Copy link
Owner

@chezou chezou commented Nov 19, 2023

Description

Close #368

Note that jpype doesn't support Python 3.12 yet, the tabula-py unit test runs without jpype on Python 3.12.

Motivation and Context

To support Python 3.12 without waiting jpype supports.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou
Copy link
Owner Author

chezou commented Nov 20, 2023

hmmm, Windows test hits this issue actions/runner#2451

@chezou
Copy link
Owner Author

chezou commented Nov 20, 2023

The above issue should be resolved by #371

@chezou chezou merged commit cefa1f4 into master Nov 20, 2023
2 checks passed
@chezou chezou deleted the py312 branch November 20, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
1 participant
@chezou