Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set encoding on SubprocessTabula initialization #371

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

chezou
Copy link
Owner

@chezou chezou commented Nov 20, 2023

Description

When calling read_pdf() after convert_into() with subprocess, -Dfile.encoding won't be set. This patch fixes the error.

Motivation and Context

Written in the description.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou chezou merged commit 635e51a into master Nov 20, 2023
2 checks passed
@chezou chezou deleted the fix-encoding branch November 20, 2023 02:21
@chezou chezou mentioned this pull request Nov 20, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant