Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Australian English helper method #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Babadzhanov
Copy link
Contributor

@Babadzhanov Babadzhanov commented Oct 6, 2019

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

fixes #40

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #55   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          50     39   -11     
  Branches        3      3           
=====================================
- Hits           50     39   -11
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26cb7e...08e778d. Read the comment docs.

Copy link
Owner

@chgasparoto chgasparoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before I merge:

  • change PR description and include the issue number to be fixed automatically when it gets merged.
  • address comment regarding CR

src/index.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Babadzhanov Babadzhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated quotes

@chgasparoto
Copy link
Owner

@Babadzhanov I just merged other PR into master. Could you please fix the conflict?

@chgasparoto chgasparoto added conflict invalid This doesn't seem right labels Oct 9, 2019
@chgasparoto
Copy link
Owner

I'll wait one more week for the conflict fix otherwise I'm going to close it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved conflict invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a helper method for Australian English
3 participants