Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete implementation and tests #2

Open
curran opened this issue Nov 30, 2015 · 1 comment
Open

Complete implementation and tests #2

curran opened this issue Nov 30, 2015 · 1 comment

Comments

@curran
Copy link
Contributor

curran commented Nov 30, 2015

The basic starting point has been created for this module. The work that remains involves adding comprehensive tests and implementing "cleanup" when the configuration changes or the injector component is destroyed.

@curran
Copy link
Contributor Author

curran commented Nov 30, 2015

@spmacdonald , if you'd like to work on this, here are some tasks that remain:

  • implement setting of the "box" property. This will be similar to setting the box property in chiasm-layout, but adapted to use each individual container.
  • un-inject all previously injected components whenever the "containers" property updates
  • un-inject all previously injected components whenever the injector component is destroyed.

TODO comments have been scattered throughout the code. I'm putting this down for now, feel free to work from this point on your own fork and send pull requests with any progress. Thanks again for volunteering to take a crack at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant