Fix router compatibility with DRF 3.8 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 12, 2018 14:34
This mixin is no longer necessary, as its features are present in DRF. There are a few minor differences thought: - Dynamic list routes no longer have a `-list` suffixed route name. - Dynamic routes are no longer first in the route order, instead the order is list, dynamic list, detail, dynamic detail.
This was referenced Apr 12, 2018
rpkilby
referenced
this pull request
in encode/django-rest-framework
Apr 13, 2018
* Merge list/detail route decorators into 'action' * Merge dynamic routes, add 'detail' attribute * Add 'ViewSet.get_extra_actions()' * Refactor dynamic route checking & collection * Refactor dynamic route generation * Add 'ViewSet.detail' initkwarg * Fixup schema test * Add release notes for dynamic action changes * Replace list/detail route decorators in tests * Convert tabs to spaces in router docs * Update docs * Make 'detail' a required argument of 'action' * Improve router docs
|
@auvipy, I also met the problem, and do you have any plans to publish new release or any other way I can use it |
|
install from git master using pip for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all. I authored encode/django-rest-framework#5705, which seems to have broken compatibility with the routers in drf-extensions. Fixing this seem seem to largely be just removing old code. Resolves #211
Changes:
ExtendedActionLinkRouterMixin. This feature seems to have been originally developed around theget_dynamic_route_viewset_method_name_by_endpointmethod, but it's no longer called. Removing the class seems to have no effects on the tests (except for a few minor changes, see commit notes).get_regex_patternto handle regex pattern compatibility. This was added in DRF 3.7.4I've ran the tests locally, and the unit and functional router tests are passing. I haven't made an attempt to fix the remaining tests, as it's outside the scope of the PR.