Add support for Godot 3 downloads

[ghost]

This PR includes:

• Suffix changes for Godot 3 files
• Updated unit tests for Godot 3
• Making Label optional when constructing SemanticVersion

Closes #31

[definitelyokay]

Wow, thanks! Just a few little tiny things.

Do you think this merits adding an additional workflow (pretty much a copy/paste of the current one) to always verify Godot 3 installation functionality?

[ghost]

Wow, thanks! Just a few little tiny things.

Do you think this merits adding an additional workflow (pretty much a copy/paste of the current one) to always verify Godot 3 installation functionality?

Ah yes, thanks for mentioning that! I just found install_test.yaml. I'll add that test as well as update the README to read Godot 3/4+.

[ghost]

@definitelyokay This is probably going to take several commits to test the workflow changes. I'll squash them once they are all passing.

[ghost]

@definitelyokay I've added a new job for 3.x install tests. I encountered an issue with the "Make sure we can build a .NET Godot game" step due to the errors in the log below. I've removed this step for the time being to ensure the others are passing.

Any advice you have here would be greatly appreciated.

Run GODOT="$(dotnet../../GodotEnv/bin/Debug/net6.0/Chickensoft.GodotEnv.d11 godot env get)"

MSBuild version 17.7.3+8ec440e68 for •NET
Determining projects to restore...
Restored /Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage/TestPackage.csproj (in 964 ms).
Restored /Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage.Tests/TestPackage.Tests.csproj (in 964 ms).
TestPackage - /Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage/nupkg/net6.0/TestPackage.d11
Successfully created package '/Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage/nupkg/TestPackage.1.0.0.nupkg'•
TestPackage.Tests ~> /Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage.Tests/•godot/mono/temp/bin/Debug/TestPackage.Tests.d11
Build succeeded.
• Warning(s)
0 Error (s)
Time Elapsed 00:00:07.09
2023-10-15 16:41:17.691 bin[2028:12376] *** [NSString stringWithUTF8String:]: NULL cString
ERROR: Can't open project at '/Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage.Tests/project.godot', its 'config_version' (5) is from a more recent and incompatible version of the engine. Expected config version: 4.
at:
load_settings_text (core/project_settings.cpp:629)
ERROR: Couldn't load file '/Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage.Tests/project.godot', error code 12.
at:
load_settings_text_or_binary (core/project_settings.срр:659)
arguments
0: /Users/runner/.config/godotenv/godot/bin
1: --headless
2: --run-tests
3: _-quit-on-finish
Current path: /Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage.Tests
Godot Engine v3.5.3.stable.mono.official.6c814135b - https://godotengine.org
OpenGL
ES 3.0 Renderer: Apple Software Renderer
Async.
shader compilation: OFF
Mono: Log file is: '/Users/runner/Library/Application Support/Godot/mono/mono_logs/2023-10-15_16.41.18_2028.1og'
ERROR: Condition "default_certs != nullptr" is true.
at: load_default_certificates (modules/mbedtls/crypto_mbedtls.cpp:314)

[definitelyokay]

Thank you for all your hard work — I'm sure godotenv users will love being able to install both versions.

I think I recognize the issue.

ERROR: Can't open project at '/Users/runner/work/GodotEnv/GodotEnv/TestPackage/TestPackage.Tests/project.godot', its 'config_version' (5) is from a more recent and incompatible version of the engine. Expected config version: 4

Godot 4 uses config_version=5 in project.godot files, whereas later Godot 3 versions (if not all?) use config_version=4 in their project.godot files. So we'd probably need to create a separate test project for building a Godot 3 project. Or we can just make sure it installs without an error and drop that from the workflow for Godot 3 — not terribly important to me unless it is to you.

From a Godot 4 project.godot file:

[ghost]

@definitelyokay thanks for the info!

I'm also fine with leaving the test step out for Godot 3. We can always add it later if we find there's a need to.

I've squashed the commits down from the tests. If you're happy with the changes, we're good to merge.

[definitelyokay]

awesome — sounds good!