Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166226540 Refactor reset password function #45

Merged
merged 3 commits into from
May 23, 2019

Conversation

chidimo
Copy link
Owner

@chidimo chidimo commented May 23, 2019

What does this PR do?

Refactor reset password function

Description of Task to be completed?

  1. Made the function into two parts. First, if the user remembers their password, and if the user doesn't

How should this be manually tested?

  1. Clone the repo
  2. cd into the root folder on a cmd shell and run yarn install. PowerShell is fine also.
  3. Setup a PostgreSQL DB.
  4. Define a .env file in the root of the project and supply values for the following parameters
    JWT_SECRET=<json-web-token-secret>
    DBNAME=<database-name>
    PGPASSWORD=<postgres-db-password>
    PGHOST=<postgres-db-host>
    PGUSER=<postgres-db-user>
    PGPORT=<postgres-db-port>
  5. Create a PostgreSQL database called testdb.
  6. Run command yarn test

Any background context you want to provide?

Nil

What are the relevant pivotal tracker stories?

166226540

Screenshots (if appropriate)

Nil

Questions:

Nil

- create scripts to create db tables on local and production environment
- Refactored because the function was too complex.

[Delivers #166226540]
@chidimo chidimo merged commit 62b6310 into develop May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant