Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto_start read side setting #42

Merged
merged 14 commits into from
May 23, 2022
Merged

feat: add auto_start read side setting #42

merged 14 commits into from
May 23, 2022

Conversation

Tochemey
Copy link
Contributor

@Tochemey Tochemey commented May 21, 2022

Feature description

This PR adds an AUTO_START setting to any readside.

  • When AUTO_START is set to true, the readside will start normally or will be resumed in case it was paused to start processing events.
  • When AUTO_START is set to false, the readside will start in paused mode which means it cannot process any events. To resume processing events one can perform any of the following actions:
    • use the CoS CLI tool to resume/restart the given read side (while CoS is still running)
    • stop CoS and set that feature to true and reboot CoS

The feature has been successfully QA with the various scenario

closes #37

@Tochemey Tochemey requested a review from zenyui as a code owner May 21, 2022 01:15
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #42 (ae5e05c) into master (9e6dbe2) will decrease coverage by 1.27%.
The diff coverage is 15.00%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   74.63%   73.36%   -1.28%     
==========================================
  Files          32       32              
  Lines         623      642      +19     
  Branches       13       17       +4     
==========================================
+ Hits          465      471       +6     
- Misses        158      171      +13     
Impacted Files Coverage Δ
.../scala/com/github/chiefofstate/AggregateRoot.scala 95.31% <ø> (ø)
...om/github/chiefofstate/config/ReadSideConfig.scala 100.00% <ø> (ø)
...github/chiefofstate/readside/ReadSideManager.scala 4.00% <0.00%> (+4.00%) ⬆️
...thub/chiefofstate/readside/ReadSideBootstrap.scala 59.52% <9.09%> (-15.48%) ⬇️
...hub/chiefofstate/config/ReadSideConfigReader.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6dbe2...ae5e05c. Read the comment docs.

@Tochemey Tochemey changed the title feat: add pause_on_start readside setting feat: add auto_start read side setting May 22, 2022
@Tochemey Tochemey requested a review from zenyui May 23, 2022 13:30
@Tochemey Tochemey merged commit d444b84 into master May 23, 2022
@Tochemey Tochemey deleted the feat-pause-read branch May 23, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants