-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add auto_start read side setting #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenyui
reviewed
May 21, 2022
code/service/src/main/scala/com/github/chiefofstate/readside/ReadSideBootstrap.scala
Outdated
Show resolved
Hide resolved
code/service/src/main/scala/com/github/chiefofstate/config/ReadSideConfig.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 74.63% 73.36% -1.28%
==========================================
Files 32 32
Lines 623 642 +19
Branches 13 17 +4
==========================================
+ Hits 465 471 +6
- Misses 158 171 +13
Continue to review full report at Codecov.
|
# Conflicts: # project/Dependencies.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature description
This PR adds an
AUTO_START
setting to any readside.AUTO_START
is set totrue
, the readside will start normally or will be resumed in case it was paused to start processing events.AUTO_START
is set tofalse
, the readside will start in paused mode which means it cannot process any events. To resume processing events one can perform any of the following actions:true
and reboot CoSThe feature has been successfully QA with the various scenario
closes #37