Add https_addr config, required to run HTTPS #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
previously approved these changes
Sep 11, 2018
|
I think it's fine to add that to the e2e tests in another PR. |
pushrax
force-pushed
the
http-and-https
branch
from
5648aa3
to
1cb16dd
Compare
|
Rebased and added the correct call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #410, by allowing both
addrandhttps_addrto be set.Should we add HTTPS to the e2e test suite?
This is a user-facing breaking change; TLS users will need to switch from
addrtohttps_addr.