Skip to content
This repository has been archived by the owner on Mar 29, 2019. It is now read-only.

Manage Issue Changesets #10

Closed
wants to merge 4 commits into from
Closed

Manage Issue Changesets #10

wants to merge 4 commits into from

Conversation

alexbevi
Copy link

This is a feature that is missing from Redmine (though there have been several patches submitted). I've taken the liberty of applying the patch to ChiliProject and now submit it for your consideration ;)

@thegcat
Copy link
Member

thegcat commented Feb 17, 2011

Hi Alex,
Please open an issue on chiliproject.org to discuss this.
Thanks.

@alexbevi
Copy link
Author

@meineerde
Copy link
Member

Issue closed as duplicate, discussion is at https://www.chiliproject.org/issues/185

@et
Copy link
Contributor

et commented Mar 3, 2011

alex, do you have any tests for this?

@alexbevi
Copy link
Author

alexbevi commented Mar 3, 2011

no. i know that rails makes testing a lot easier, but it's still not something i've ever really gotten into. I'll try to write some eventually, but I'm not really sure where to start. Any pointers?

@et
Copy link
Contributor

et commented Mar 5, 2011

Alex, this looks like a lot of changes, so it's hard to direct you to something small. The best pointer i can give you is to start over and write your tests first.
Also, it looks like you merged your test branch into your master branch. I'm pretty sure the proper way is to create a pull request from your test branch, not from your master (unless it's a trivial change) since it adds an unnecessary merge message to the log.

@meineerde meineerde closed this Feb 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants