This repository has been archived by the owner on Mar 29, 2019. It is now read-only.
Pulls/667/label elements #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added invisible label
added "no-css" class to overwrite the current label style
linked label where possible
even for sighted users
This reverts commit 6598af4.
Another possibility is just to use the :builder => ActionView::Helpers::FormBuilder option in subforms/form_fors to work around lugging the TabularFormBuilder around if that isn't needed/wished
|
Rebased and merged into master. The code is in ChiliProject 2.4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit contains all accessibility fixes I could find. Either I linked existing labels to their elements or I created invisible ones only screenreaders will see.
The last commit is optional, it makes the labels on column selection for the issue list visible. In my opinion this is an accessibility issue even for sighted users.
Translations are given in german and english.
Feel free to comment.
Regards Romano