This repository has been archived by the owner on Mar 29, 2019. It is now read-only.
Added fast hack to resolve project menu height problem #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -564,6 +564,12 @@ jQuery(document).ready(function($) { | |||
| $('#account-nav .drop-down').live('click', function(event) { | |||
| var menuItem = $(this); | |||
|
|
|||
| var windowHeight = Math.floor($.viewportHeight() * 0.8); | |||
There was a problem hiding this comment.
Using a percentage value means that bigger screens end up having a lot of wasted space at the bottom of the page, perhaps using a fixed pixel value might be nicer (e.g. $.viewportHeight() == 1342 for me so there's about 270px wasted).
|
The intial idea on the 80% window height was for the "beauty" of UI coherence. And it is adaptive to all window heights (I have 2 screens with 2 different heights). |
|
Thanks for your contribution, I ended up merging #199 though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have about 150 projects in Chiliproject. As it is right now, the project menu (upper selector button) is about 5 times the actual page height. With the little piece of JS the height is set to 80% of the window height, but only if the menu height is greater then the page height. Then it adds a scrollbar to the menu.