Skip to content
This repository has been archived by the owner on Jun 5, 2018. It is now read-only.

add support for versioning on S3 #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for versioning on S3 #140

wants to merge 1 commit into from

Conversation

techtribe
Copy link
Contributor

enabled support for unrequired resource-variables like versioning (on
S3).

enabled support for unrequired resource-variables like versioning (on
S3).
@ghost ghost assigned chilts Dec 17, 2012
@techtribe
Copy link
Contributor Author

While I couldn't find any examples for s3.PutBucketAcl & s3.PutBucketCors (which are the only ones that use "resource" as non-required parameter) that it would be a best practice to use the following structure if you want to add the "resource"-parameter to your request:

s3.ListObjects :

Versions:true = works
Versions:"true" = works
Versions:"false" = does not work
Versions:false = does not work
Versions:undefined = does not work

which will imply that examples for s3.PutBucketAcl & s3.PutBucketCors will need to have the above examples (how to enable an s3-put-bucket-example) to make it work.

@chilts are you okay with this approach, or do you have another solution? In the old/previous setup "required"-parameter was ignored (at awssum.js at line 501), so it was always sent even if you didn't put in the params-object in your request/call.

@kriangkraikaewbappha
Copy link

mQINBFh1XPABEADXorlGKWsNvc3woSZ

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants