Added pop() method to ConfigTree and added KeyError to ConfigMissingException #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've added a pop() method to the ConfigTree class, and I'm 99% sure that I've done it correctly. Wanted to submit a pull request so that I don't have to keep patching locally. :-) I tried to cover all the edge cases in the test case, but I may have miss something.
Additionally, I added KeyError to the inheritance list for ConfigMissingException so that you can use it more like a dictionary, like:
The only thing I'm not entirely sure of is line 225-227. It works, although I wasn't sure if you guys had a more preferred way to split/join key names
My commit msg: