Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose ProxyServer #190

Closed
wants to merge 1 commit into from
Closed

Conversation

legokichi
Copy link

@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage increased (+0.009%) to 97.076% when pulling d7f21b2 on legokichi:legokichi-patch-1 into dc014c8 on chimurai:master.

@chimurai
Copy link
Owner

Thanks for the PR @legokichi

Are the any reasons to expose the whole proxy server instead of just the close function?

@legokichi
Copy link
Author

legokichi commented Aug 17, 2017

@chimurai In addition to calling methods of the ProxyServer class, we can also call methods of http/https class. It becomes easy to hack. But adding middleware.close is sufficient for my use. This pull request is one of the proposals.

@judikdavid
Copy link

Exposing a proxy server would be good to handle POST requests as well, like shown here:
http-party/node-http-proxy#1142 (comment)
Without that, the middleware cannot proxy POST API requests.

@chimurai
Copy link
Owner

@judikdavid
Copy link

@chimurai Thank you, did not noticed that option 💯

@chimurai
Copy link
Owner

fixed in #508

proxy closes automatically with a graceful server shutdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants