Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hujun 20180923 #117

Merged
merged 8 commits into from
Oct 11, 2018
Merged

Hujun 20180923 #117

merged 8 commits into from
Oct 11, 2018

Conversation

mindjun
Copy link
Contributor

@mindjun mindjun commented Oct 11, 2018

add functiontransform_hump_to_underline, transform_datetime_to_unix, doc and unittest;

@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 228

  • 16 of 18 (88.89%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+6.3%) to 88.256%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fishbase/fish_common.py 9 10 90.0%
fishbase/fish_date.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
fishbase/fish_common.py 4 89.5%
Totals Coverage Status
Change from base Build 219: 6.3%
Covered Lines: 248
Relevant Lines: 281
💛 - Coveralls

@itaa itaa merged commit cd50435 into v1.1.1_develop Oct 11, 2018
@mindjun mindjun deleted the hujun_20180923 branch October 28, 2018 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mindjun @coveralls @itaa