Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonic value DC not handled properly by Synergize #28

Closed
chinenual opened this issue Dec 17, 2020 · 2 comments
Closed

Harmonic value DC not handled properly by Synergize #28

chinenual opened this issue Dec 17, 2020 · 2 comments
Assignees
@chinenual
Labels
bug Something isn't working

Comments

@chinenual
Copy link
Owner

chinenual commented Dec 17, 2020 •
edited
Loading

In investigating Ross T's question about the meaning of "DC" as a harmonic value, Jari noticed an oddity in the values being sent by Synergize.

I've since compared SYNHCS vs. Synergize and can confirm that

  • Synergize sends value 31 (0x1f) for "dc"
  • SYHNCS sends value -2 (0xf4)

Similar mistake is made in the value stored in the edited VCE.
@chinenual chinenual self-assigned this Dec 17, 2020
@chinenual chinenual added the bug Something isn't working label Dec 17, 2020
chinenual added a commit that referenced this issue Dec 17, 2020
@chinenual
fixes #28 - dc sends 0xf4 instead of 0x1f
06f5e7f
@chinenual
Copy link
Owner Author

Fixed for 2.3.1

@chinenual
Copy link
Owner Author

Fixed in 2.3.1

@chinenual chinenual mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chinenual chinenual

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chinenual