Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 65/add styling and button to modal #69

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Issue 65/add styling and button to modal #69

merged 3 commits into from
Nov 1, 2023

Conversation

rosscondie
Copy link
Contributor

What?

  • Update name of component Modal,js to WelcomeModal,js for clarity.
  • Add custom welcome message to user depending on time of day. (see screenshot below)
  • Add descriptive text to explain the use of the application.
  • Add styling to give modal box extra shadow effect for cleaner look.
  • Add styling to text for darker shade of grey for readability.
  • Add styling to button for improved user interaction.

Screenshots (optional)

image

Screenshot 2023-10-30 at 19 45 03

Closes #65

@rosscondie rosscondie added the enhancement New feature or request label Oct 30, 2023
@rosscondie rosscondie added this to the Sprint 5 milestone Oct 30, 2023
@rosscondie rosscondie self-assigned this Oct 30, 2023
@rosscondie
Copy link
Contributor Author

This PR also Closes #70

@futurefounder
Copy link
Contributor

Great work, love the greeting based on time of the day and the clean styling. We can think about adding an emoji or two at a later stage. 🚀

@futurefounder futurefounder merged commit 208b45c into development Nov 1, 2023
1 check passed
@futurefounder futurefounder deleted the issue-65/add-styling-and-button-to-modal branch November 1, 2023 08:41
kelvinSeamount pushed a commit that referenced this pull request Nov 2, 2023
@futurefounder
Merge pull request #69 from chingu-voyages/issue-65/add-styling-and-b…
16b7b3a 
…utton-to-modal

Issue 65/add styling and button to modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futurefounder futurefounder Awaiting requested review from futurefounder

@kelvinSeamount kelvinSeamount Awaiting requested review from kelvinSeamount

Assignees

@rosscondie rosscondie

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 5
Development

Successfully merging this pull request may close these issues.

Add styling, copy and button to welcome Modal
2 participants
@rosscondie @futurefounder