Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scroll functionality #87

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

kelvinSeamount
Copy link
Contributor

What

This pull request brings about the functionality where the user inputs a query and the API results is display and set 5 items per page and pagination option with smooth scroll functionality.
I had to refactored the code as i was not able to use (.then promises).

Closes #86

@futurefounder
Copy link
Contributor

Hi Emeka,
thanks for your effort on this pretty tough task, some things are working, but some things aren't.
I see the following issue:

Card components not displaying correctly

The Card components are

  • Missing the tags
  • Missing the View recipe button
  • Aligned with only one card per line
  • Text "Showing page 1 of x" does not add value and is displayed during the loading, can be taken out
  • Then for loading you replaced the loading spinner from DaisyUI with the text 'Loading' is there a reaosn for that? If not, I would recomment staying with the Loading spinner from DaisyUI

image
image

If the result component are shown correctly on your local machine, please add a screenshot of the expected behaviour.

That's it, thanks again!

@futurefounder
Copy link
Contributor

I created a propesed fix for the cards being wrongly styled and tags being wrongly displayed issue. Nevertheless the way in which the cards are displayed and the state of the search query being lost are not optimal for UX, which is why I would not merge into development at this stage.

Still, great attempt and we nearly got there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollable List Display Results from API
2 participants