Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/techs test #103

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Feature/techs test #103

merged 3 commits into from
Feb 20, 2024

Conversation

JoshuaHinman
Copy link
Contributor

Description

E2E tests for the following routes (techs):
GET /api/v1/voyages/{teamId}/techs
POST /api/v1/voyages/{teamId}/techs
POST /api/v1/voyages/{teamId}/techs/{teamTechId}
DELETE /api/v1/voyages/{teamId}/techs/{teamTechId}

These tests verify the expected request/response behavior for these routes and changes to the database.

Set global timeout limit to 30 seconds in jest-e2e.json

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yarn test:e2e techs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

cherylli
cherylli previously approved these changes Feb 19, 2024
Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all tests passed.
I think there's some confusion with the Changelog but i'll make some adjustments after this is merged

test/techs.e2e-spec.ts Outdated Show resolved Hide resolved
@JoshuaHinman JoshuaHinman merged commit 5546921 into dev Feb 20, 2024
1 check passed
@JoshuaHinman JoshuaHinman deleted the feature/techs-test branch February 20, 2024 02:41
@cherylli cherylli mentioned this pull request Feb 27, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants