Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email templates to use domain in env variables #110

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented Mar 5, 2024

update email template to use domain based on env variables

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

created a new email account and sent a test email
image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working here

@cherylli
Copy link
Collaborator Author

cherylli commented Mar 5, 2024

url is wrong, it has an extra / but that's because I set the wrong env variable 😂, fixed it on railway now

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested email routes - got 200s

@cherylli cherylli merged commit 9770f2c into dev Mar 7, 2024
1 check passed
@cherylli cherylli deleted the fix/email-template-urls branch March 7, 2024 06:17
@curtwl curtwl restored the fix/email-template-urls branch March 15, 2024 18:13
@curtwl curtwl deleted the fix/email-template-urls branch March 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants