-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multiple device #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for me locally, and all tests passed. Just need to resolve some conflicts 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! All tests passed locally. Also I have followed your test directions in both chrome and firefox. After that, I checked pgadmin saw the jessica
had two refresh tokens.
Description
Adds support for users logging in from multiple devices by changing refreshToken to a scalar array. Login now checks to see if the user has a refresh token in the current device's cookies, and if so, replaces the existing token instead of adding a new one.
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Aside from updating the e2e tests, I also tested by logging in as Jessica from 3 different browsers and spamming the login and refresh routes with Swagger, to confirm that tokens are replaced instead of growing the array indefinitely.
Checklist: