Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/voyage submission #133

Merged
merged 12 commits into from
Apr 17, 2024
Merged

Feature/voyage submission #133

merged 12 commits into from
Apr 17, 2024

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented Apr 14, 2024

Description

Add voyage project submission feature

  • table to store submissions (FormResponseVoyageProject)
  • controller (POST voyages/submit-project)
  • services
  • e2e tests
  • sample responses

TODO:

  • Generate db migration
  • Fix broken unit test due to adding new voyage module

Issue link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested manually on swagger and with e2e tests
image
image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this Apr 14, 2024
@cherylli cherylli marked this pull request as ready for review April 14, 2024 14:11
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e tests passed, but I had a problem on swagger. The example request returned 409 for me
image

@cherylli
Copy link
Collaborator Author

The e2e tests passed, but I had a problem on swagger. The example request returned 409 for me image

@JoshuaHinman Thanks for checking this out! That's because I populated the database with seed using voyageTeam1, and each team can only submit the project once. It should work if you use voyageTeamId = 2

Maybe I should change the sample to voyageTeam2

@cherylli
Copy link
Collaborator Author

Updated sample req body to teamId 2, also added a note to the description

Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!Swagger and tests pass

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test passed and swagger responses verified!

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@cherylli cherylli merged commit 94b06f0 into dev Apr 17, 2024
1 check passed
@cherylli cherylli deleted the feature/voyage-submission branch April 17, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants