Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 401 responses to sprints endpoints and swagger docs #157

Merged
merged 2 commits into from
May 25, 2024

Conversation

JoshuaHinman
Copy link
Contributor

Description

This PR adds a standard 401 response for all Sprints endpoints, when the user is not logged in. These changes are shown in the swagger documentation and in e2e tests for all routes

Issue link

Fixes # 86azuu45a

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Verified in swagger and in sprints e2e tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! everything works fine for me

Copy link
Collaborator

@Ajen07 Ajen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are working as expected and all the tests runs perfectly.

@JoshuaHinman JoshuaHinman merged commit c25f695 into dev May 25, 2024
1 check passed
@JoshuaHinman JoshuaHinman deleted the update/sprints-unauthorized branch May 25, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants