-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/@api response features & ideations #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about a few changes (marked by github) as I can't visually see any changes ->
What changed in the migration, and schema.prisma file? I can't see the difference
What package was added for this PR? (since an updated yarn file was commited)
Thanks for catching these, I accidentally did a npm install cause I was switching between projects. Thought I caught and reversed the changes but failed. Do you know, if I delete these files in my branch will it affect Dev in the merge? I tried deleting and merging dev into my branch but it doesn't show any differences to merge in. Worst case I might make a new branch. |
yeah if you delete them, they will be deleted on merge. I think what you can do is to unstage those files and commit again, then they should not appear as "changed" |
22d8c25
to
c583a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue link
Fixes #65
Type of change
How Has This Been Tested?
tested on swagger
Checklist: