Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/alignment of page content #27

Merged
merged 6 commits into from
Sep 24, 2023
Merged

Conversation

timothyrusso
Copy link
Collaborator

Description

Fix the layout of the page content.
Add the Banners for the Tech Stack page and the Directory page.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 6:36am

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues related to responsiveness that will require changes in the ui. Eury is working on the design in figma. Will update when those are finished.

Dan-Y-Ko
Dan-Y-Ko previously approved these changes Sep 24, 2023
Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to take care of the responsive implementation in separate prs. This one is good to merge.

@timothyrusso timothyrusso dismissed Dan-Y-Ko’s stale review September 24, 2023 06:34

The merge-base changed after approval.

Dan-Y-Ko
Dan-Y-Ko previously approved these changes Sep 24, 2023
Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again...

@Dan-Y-Ko Dan-Y-Ko merged commit 1a38d56 into dev Sep 24, 2023
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the fix/alignment-of-page-content branch September 24, 2023 06:37
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants