Fix reconnecting issues #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on native android on each connect
chinloyal
reviewed
Feb 2, 2021
| @@ -12,6 +12,8 @@ abstract class StreamHandler { | |||
| /// Add a listener to the event channel stream for pusher, | |||
| /// any class that extends [StreamHandler] should use this method. | |||
| void registerListener(String classId, dynamic Function(dynamic) method) { | |||
| _eventStreamSubscription?.cancel(); | |||
There was a problem hiding this comment.
With this line are you able to receive connection state change events after binding to an event? Because whenever you bind it calls registerListener so wouldn't this line cancel the stream causing all classes using the event channel to not receive any events?
There was a problem hiding this comment.
Yes, connection state changes still work after binding because Channel and PusherClient extend this abstract class on their own. bind() and connect() only re-subscribes their own instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on Android when doing:
we no longer receive onConnectionStateChange updates
This change will add or replace a streamsubscription on each connect(), which fixes the issue.
Also, each call to connect added another ConnectionListener instance which duplicated calls being sent to flutter, which should now be fixed.